Chore/ Update Electron & ChromeDriver to v38#252
Closed
gwleuverink wants to merge 13 commits intomainfrom
Closed
Conversation
rollup would create another level of nesting which required to change imports in multiple places. I'd rather not touch any other imports for this change. Moving everything inside the plugin src directory has the least impact across unrelated files
…' of github.com:NativePHP/electron into chore/pull-in-blocking-menubar-lib-and-upgrade-electron
…' of github.com:NativePHP/electron into chore/pull-in-blocking-menubar-lib-and-upgrade-electron
gwleuverink
changed the title
v38
gwleuverink
changed the title
v38v38
Contributor
Author
|
I put the vendored libraries in That's why I opted to put the vendored libs in |
simonhamp
approved these changes
Sep 5, 2025
Member
simonhamp
left a comment
simonhamp
left a comment
There was a problem hiding this comment.
This is great, but I think when we release this it will need to be a v2. These breaking changes feel like something we need to call out pretty clearly
Contributor
Author
|
Agreed 💯 |
SRWieZ
approved these changes
Sep 12, 2025
Closed
Member
|
Already merged in https://github.com/NativePHP/desktop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/NativePHP/laravel/issues/390
This PR updates to the latest versions of Electron & ChromeDriver
The Menubar package was blocking the update before. So I had to pull it in as a vendored library as suggested here #233 (comment)
This update introduces some breaking changes
https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-340
https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-350
https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-360
https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-370
https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-380
Most notably dropping support for macOS Catalina & Big Sur. I don't think the other things affect us, would appreciate double verification on that 🙏🏻